Update release candidate branch to 3.2.0rc0 by lbdreyer · Pull Request #78 · conda-forge/iris-feedstock

lbdreyer · 2022-01-31T17:44:04Z

To create this I took a copy of the recipe from master, updated it to v3.2.0rc0.

Checklist

Used a personal fork of the feedstock to propose changes
Bumped the build number (if the version is unchanged)
Reset the build number to 0 (if the version changed)
Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
Ensured the license file is being packaged.

conda-forge-linter · 2022-01-31T17:44:08Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

lbdreyer · 2022-01-31T17:44:26Z

@conda-forge-admin, please rerender

…nda-forge-pinning 2022.01.29.15.10.18

bjlittle · 2022-02-01T12:57:35Z

@conda-grayskull show requirements

conda-grayskull · 2022-02-01T13:01:37Z

Working on your request...

bjlittle

@lbdreyer Looking good, but I've got a couple of outstanding questions, thanks 👍

bjlittle · 2022-02-01T13:28:10Z

recipe/meta.yaml

+  - name: scitools-iris
+    build:
+      noarch: generic
+    requirements:
+      run:
+        - {{ pin_subpackage('iris', max_pin="x.x.x") }}
+    test:
+      imports:
+        - iris
 about:


@lbdreyer What's the advantage of doing this?

I guess it is a minimal check that it built correctly.

Isn't that what lines 34-36 are doing?

My interpretation was that they were separate builds, so they each needed testing (this was originally done in https://github.com/conda-forge/iris-feedstock/pull/74/files).

I will have to do a bit more reading to check this though!

Not sure if helpful, but I found some other examples of where there is a test for each build output:
https://github.com/conda-forge/typing_extensions-feedstock/blob/master/recipe/meta.yaml#L28-L40
and
https://github.com/conda-forge/gstreamer-feedstock/blob/master/recipe/meta.yaml#L49

@ocefpaf Do you have any guidance/opinion on this?

No strong opinion but I'd keep the extra test b/c it ensure the multiple output is working.

recipe/meta.yaml

bjlittle · 2022-02-01T13:33:15Z

recipe/conda_build_config.yaml

-channel_targets:
-  - conda-forge rc_iris


@lbdreyer As this is a pre-release, don't we want to populate the rc_iris channel instead of main?

See https://conda-forge.org/docs/maintainer/knowledge_base.html#pre-release-builds

recipe/build_base.sh

conda-forge-linter · 2022-02-01T15:03:14Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

Jinja2 variable references are suggested to take a {{<one space><variable name><one space>}} form. See lines [17].

lbdreyer · 2022-02-01T15:03:49Z

Thanks for the review @bjlittle !
I believe I have addressed your comments now.

recipe/meta.yaml

Co-authored-by: Bill Little <bill.little@metoffice.gov.uk>

conda-forge-linter · 2022-02-01T15:31:38Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

lbdreyer · 2022-02-01T15:56:40Z

@conda-forge-admin, please rerender

…nda-forge-pinning 2022.02.01.15.47.50

lbdreyer · 2022-02-02T13:25:10Z

@bjlittle This should now be good to go. I finally figured out why it was failing. It turns out I had the build script line "python -m pip install ..." in the wrong place.
Do you mind having another look at this?

bjlittle · 2022-02-03T12:29:17Z

@lbdreyer Awesome, thanks 🥳

Update release candidate branch to 3.2.0rc0

fc0d452

lbdreyer requested review from DPeterK, bjlittle, corinnebosley, ocefpaf, pelson, pp-mo and rhattersley as code owners January 31, 2022 17:44

MNT: Re-rendered with conda-build 3.21.7, conda-smithy 3.16.2, and co…

3bf4873

…nda-forge-pinning 2022.01.29.15.10.18

bjlittle requested changes Feb 1, 2022

View reviewed changes

bjlittle reviewed Feb 1, 2022

View reviewed changes

recipe/build_base.sh Outdated Show resolved Hide resolved

Review actions

4562cca

bjlittle reviewed Feb 1, 2022

View reviewed changes

recipe/meta.yaml Outdated Show resolved Hide resolved

Update recipe/meta.yaml

7179e2a

Co-authored-by: Bill Little <bill.little@metoffice.gov.uk>

forgot the conbuild config

1a667c8

conda-forge-webservices[bot] and others added 2 commits February 1, 2022 15:57

MNT: Re-rendered with conda-build 3.21.7, conda-smithy 3.16.2, and co…

bfa9b09

…nda-forge-pinning 2022.02.01.15.47.50

move python build script

d7cd680

lbdreyer force-pushed the 320rc0_update branch from 62b8e4c to d7cd680 Compare February 2, 2022 13:15

bjlittle approved these changes Feb 3, 2022

View reviewed changes

bjlittle merged commit 462be7f into conda-forge:release-candidate Feb 3, 2022

Uh oh!

Conversation

lbdreyer commented Jan 31, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

conda-forge-linter commented Jan 31, 2022

Uh oh!

lbdreyer commented Jan 31, 2022

Uh oh!

bjlittle commented Feb 1, 2022

Uh oh!

conda-grayskull commented Feb 1, 2022

Uh oh!

bjlittle left a comment

Choose a reason for hiding this comment

Uh oh!

bjlittle Feb 1, 2022

Choose a reason for hiding this comment

Uh oh!

lbdreyer Feb 1, 2022

Choose a reason for hiding this comment

Uh oh!

bjlittle Feb 1, 2022

Choose a reason for hiding this comment

Uh oh!

lbdreyer Feb 1, 2022

Choose a reason for hiding this comment

Uh oh!

lbdreyer Feb 1, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bjlittle Feb 1, 2022

Choose a reason for hiding this comment

Uh oh!

ocefpaf Feb 1, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bjlittle Feb 1, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

conda-forge-linter commented Feb 1, 2022

Uh oh!

lbdreyer commented Feb 1, 2022

Uh oh!

Uh oh!

conda-forge-linter commented Feb 1, 2022

Uh oh!

lbdreyer commented Feb 1, 2022

Uh oh!

lbdreyer commented Feb 2, 2022

Uh oh!

bjlittle commented Feb 3, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

lbdreyer commented Jan 31, 2022 •

edited

Loading

lbdreyer Feb 1, 2022 •

edited

Loading

bjlittle Feb 1, 2022 •

edited

Loading